Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chow #27228

Open
sorger-c opened this issue Feb 5, 2019 · 19 comments
Open

Chow #27228

sorger-c opened this issue Feb 5, 2019 · 19 comments

Comments

@sorger-c
Copy link

sorger-c commented Feb 5, 2019

CC: @fchapoton

Component: algebraic geometry

Author: Christoph Sorger

Branch/Commit: public/ticket-chow @ f263ba5

Issue created by migration from https://trac.sagemath.org/ticket/27228

@sorger-c sorger-c added this to the sage-8.7 milestone Feb 5, 2019
@sorger-c sorger-c self-assigned this Feb 5, 2019
@sorger-c
Copy link
Author

sorger-c commented Feb 6, 2019

Author: Christoph Sorger

@sorger-c
Copy link
Author

sorger-c commented Feb 6, 2019

Branch: u/gh-sorger-c/chow

@sorger-c
Copy link
Author

sorger-c commented Feb 7, 2019

New commits:

8102668Added the package Chow, a library for computations in intersection theory.

@sorger-c
Copy link
Author

sorger-c commented Feb 7, 2019

Commit: 8102668

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 7, 2019

Changed commit from 8102668 to 06f8480

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 7, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

06f8480The package has been updated to work with version 8.7 of Sage.

@embray
Copy link
Contributor

embray commented Mar 25, 2019

comment:7

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

@embray embray modified the milestones: sage-8.7, sage-8.8 Mar 25, 2019
@embray
Copy link
Contributor

embray commented Jun 14, 2019

comment:8

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

@embray embray removed this from the sage-8.8 milestone Jun 14, 2019
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 4, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

48d6a43Added the package Chow, a library for computations in intersection theory.
a58edecThe package has been updated to work with version 8.7 of Sage.
b5769acUpdated to Python3. Works with Sage 9.0
23c70fcMerge branch 'u/gh-sorger-c/chow' of git://trac.sagemath.org/sage into t/27228/chow

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 4, 2020

Changed commit from 06f8480 to 23c70fc

@fchapoton
Copy link
Contributor

comment:10

Salut Christoph,

  • petite suggestion, dans la definition de la fonction todd(), eviter d'utiliser l'anneau symbolique SR, mais utiliser soit directement les nombres de Bernoulli, soit l'anneau des series formelles
sage: x = PowerSeriesRing(QQ,'x', default_prec=24).gen().O(24)
sage: x/(1-exp(x))
-1 + 1/2*x - 1/12*x^2 + 1/720*x^4 - 1/30240*x^6 + 1/1209600*x^8 - 1/47900160*x^10 + 691/1307674368000*x^12 - 1/74724249600*x^14 + 3617/10670622842880000*x^16 - 43867/5109094217170944000*x^18 + 174611/802857662698291200000*x^20 - 77683/14101100039391805440000*x^22 + O(x^23)
  • peut-etre que ca serait bien de mettre ton package sous la forme d'un package python, plus facile à installer pour les gens. Je ne suis pas un expert dans ce genre de chose, mais il y a des instructions ici, qui pèsent le pour et le contre:

https://wiki.sagemath.org/CodeSharingWorkflow

https://gist.github.com/cswiercz/c632d920565a2da519b73bd2b79d7920

https://github.com/sagemath/sage_sample

@sorger-c
Copy link
Author

sorger-c commented May 4, 2020

comment:11

Salut Frédéric,

Merci pour les deux suggestions. Je vais regarder comment éviter l'utilisation de SR, peut-être avec l'anneau des séries formelles ou, effectivement, le faire directement via les nombres de Bernoulli.

En ce qui concerne le packaging, oui, c'est une piste à suivre, merci pour les liens! On me demande parfois comment installer chow et la forme actuelle d'une branche est un peu compliquée pour les collègues qui n'ont pas l'habitude de git. Aussi il faut compiler sage ce qui est délicat parfois (je n'ai pas réussi à compiler la branche develop aujourd'hui sur mon Mac, puisque pynac et matplotlib bloquaient) et surtout très long... Je vais regarder sage_sample plus en détail (et les remarques de Nicolas sur le workflow).

Là aujourd'hui, j'ai juste voulu rendre la branche compatible avec Sage 9.0 et Python3. Ce n'était pas très difficile, essentiellement quelques imports, l'utilisation de basestring et une division a/b à modifier. Au moins, tous les tests passent à nouveau.

@jhpalmieri
Copy link
Member

comment:12

See https://math.stackexchange.com/questions/4574286/sage-chow-package-install-merge-error: the branch no longer merges cleanly.

@fchapoton
Copy link
Contributor

Changed branch from u/gh-sorger-c/chow to public/ticket-chow

@fchapoton
Copy link
Contributor

Changed commit from 23c70fc to 66676ed

@fchapoton
Copy link
Contributor

New commits:

66676edMerge branch 'u/gh-sorger-c/chow' in 9.8.b3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

5d6eb80Merge branch 'develop' into t/27228/public/ticket-chow
f263ba5Works with 9.8.beta6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2022

Changed commit from 66676ed to f263ba5

@giannipetrella
Copy link

giannipetrella commented Feb 7, 2025

Is someone working on finishing this integration? An intersection theory interface would be a pretty important feature for algebraic geometry, and it'd be nice for Chow to ship directly with Sage...
I’d be happy to take on this task myself if not :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants