You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
If you are interested in working on this issue or have submitted a pull request, please leave a comment.
Describe the user story
I've noticed that the author of the PR can approve the policies if they are listed as a team member/user of the approver. Does it make sense to be able to control this? There are some sensitive repos where we don't want to allow this.
Describe the solution you'd like #4794 --> The solution is to have a flag allowing self-approval and defaulting to false.
Describe the drawbacks of your solution
One drawback of this solution is that now, it will default to false which means that the author would not have the ability to approve the pr without selfApprove being explicitly set to true.
The text was updated successfully, but these errors were encountered:
Community Note
Describe the user story
I've noticed that the author of the PR can approve the policies if they are listed as a team member/user of the approver. Does it make sense to be able to control this? There are some sensitive repos where we don't want to allow this.
Describe the solution you'd like
#4794 --> The solution is to have a flag allowing self-approval and defaulting to false.
Describe the drawbacks of your solution
One drawback of this solution is that now, it will default to
false
which means that the author would not have the ability to approve the pr withoutselfApprove
being explicitly set totrue
.The text was updated successfully, but these errors were encountered: