Allow --gh-team-allowlist to work with team names and slugs

[nitrocode]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

• I'd be willing to implement this feature (contributing guide)

Describe the user story

The gh team allowlist seems like it should work for slugs but it only works with names.

Related doc PRs

• docs: updates docs on gh-team-allowlist #2664
• docs: fix incorrect wildcard and more precise instruction to --gh-team-allowlist option. #2005

Possibly related discussion #2716

Describe the solution you'd like

Allow both slug or name.

The Node exposes Name but also exposes Slug and we only append the Name.

atlantis/server/events/vcs/github_client.go

Line 524 in f3bf05e

func (g *GithubClient) GetTeamNamesForUser(repo models.Repo, user models.User) ([]string, error) {

atlantis/server/events/vcs/github_client.go

Lines 531 to 537 in f3bf05e

	var q struct {
	Organization struct {
	Teams struct {
	Edges []struct {
	Node struct {
	Name string
	}

atlantis/server/events/vcs/github_client.go

Lines 553 to 555 in f3bf05e

	for _, edge := range q.Organization.Teams.Edges {
	teamNames = append(teamNames, edge.Node.Name)
	}

This function is called here

atlantis/server/events/command_runner.go

Lines 198 to 202 in f3bf05e

	teams, err := c.VCSClient.GetTeamNamesForUser(repo, user)
	if err != nil {
	return false, err
	}
	ok := c.TeamAllowlistChecker.IsCommandAllowedForAnyTeam(teams, cmd.Name.String())

atlantis/server/events/team_allowlist_checker.go

Lines 43 to 72 in f3bf05e

	func (checker *TeamAllowlistChecker) IsCommandAllowedForTeam(team string, command string) bool {
	for _, rule := range checker.rules {
	for key, value := range rule {
	if (key == wildcard || strings.EqualFold(key, team)) && (value == wildcard || strings.EqualFold(value, command)) {
	return true
	}
	}
	}
	return false
	}
	// IsCommandAllowedForAnyTeam returns true if any of the teams is allowed to execute the command
	// and false otherwise.
	func (checker *TeamAllowlistChecker) IsCommandAllowedForAnyTeam(teams []string, command string) bool {
	if len(teams) == 0 {
	for _, rule := range checker.rules {
	for key, value := range rule {
	if (key == wildcard) && (value == wildcard || strings.EqualFold(value, command)) {
	return true
	}
	}
	}
	} else {
	for _, t := range teams {
	if checker.IsCommandAllowedForTeam(t, command) {
	return true
	}
	}
	}
	return false

Describe the drawbacks of your solution

Additional logic to check for both

Describe alternatives you've considered

None