Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atlantis does not detect projects with updated .terraform.lock.hcl #1970

Closed
llamahunter opened this issue Jan 3, 2022 · 1 comment · Fixed by #1991
Closed

Atlantis does not detect projects with updated .terraform.lock.hcl #1970

llamahunter opened this issue Jan 3, 2022 · 1 comment · Fixed by #1991
Labels
bug Something isn't working

Comments

@llamahunter
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

When a deployment is updated just to update the .terraform.lock.hcl file (e.g. to get newer provider implementations that may change deployed resources), atlantis does not identify the project containing the .terraform.lock.hcl file as needing a new plan.

Reproduction Steps

  1. Create a project with a .terraform.lock.hcl and some terraform
  2. Create a PR just to change the .terraform.lock.hcl and no other .tf files
  3. Note that when atlantis runs on the PR, it detects 0 projects needing new plans
  4. However, running terraform plan manually on the command line may show that there are changed resources.

Logs

N/A

Environment details

N/A

Additional Context

N/A

@llamahunter llamahunter added the bug Something isn't working label Jan 3, 2022
@gezb
Copy link
Contributor

gezb commented Jan 11, 2022

I have just created a PR that should fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants