Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to prevent circumventing the mergeable rule for applying a plan in GitHub? #1407

Closed
wsams opened this issue Feb 12, 2021 · 3 comments
Labels
waiting-on-response Waiting for a response from the user

Comments

@wsams
Copy link

wsams commented Feb 12, 2021

Hello, I set up an Atlantis instance that requires a PR to be mergeable before running 'apply'.

However, if I create a branch "A" of "master", then another branch "B" from "A", "B" can be merged into "A" without approval. And therefore I can apply plans without approval. I'm currently only protecting the "master" branch (requires approval).

Is there a way to prevent this kind of scenario? I think I would need to protect all branches. Any ideas or thoughts on this problem?

Thanks,
Weldon

@ghostsquad
Copy link

Basically you want to be able to restrict that applies only happen for PRs that are merging into your default branch (or some set of branches). AFAIK, this is not configurable in Atlantis, so ya, this sounds like a good feature to add.

@nishkrishnan
Copy link
Contributor

I think this addresses it no? #1383

@nishkrishnan nishkrishnan added the waiting-on-response Waiting for a response from the user label Feb 25, 2021
@wsams
Copy link
Author

wsams commented Feb 25, 2021

I think this addresses it no? #1383

Hi @nishkrishnan , I believe that does solve the issue. I misunderstood how branch functions. I haven't tested, but after looking over #1383 I'll go ahead and close this issue.

Many thanks,
Weldon

@wsams wsams closed this as completed Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-response Waiting for a response from the user
Projects
None yet
Development

No branches or pull requests

3 participants