Skip to content

Commit ac049ea

Browse files
committed
Improve error logging
1 parent 23c5cd9 commit ac049ea

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

server/events/vcs/github_client.go

+4-2
Original file line numberDiff line numberDiff line change
@@ -463,11 +463,13 @@ func (g *GithubClient) GetTeamNamesForUser(repo models.Repo, user models.User) (
463463
for {
464464
teams, resp, err := g.client.Teams.ListTeams(g.ctx, org, opts)
465465
if err != nil {
466-
return nil, err
466+
return nil, errors.Wrap(err, "retrieving GitHub teams")
467467
}
468468
for _, t := range teams {
469469
membership, _, err := g.client.Teams.GetTeamMembershipBySlug(g.ctx, org, *t.Slug, user.Username)
470-
if err == nil && membership != nil {
470+
if err != nil {
471+
g.logger.Err("Failed to get team membership from GitHub: %s", err)
472+
} else if membership != nil {
471473
if *membership.State == "active" && (*membership.Role == "member" || *membership.Role == "maintainer") {
472474
teamNames = append(teamNames, t.GetName())
473475
}

0 commit comments

Comments
 (0)