Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take away block hash, block index dups processing script from migration to script #2958

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Jan 17, 2020

Relates to

Motivation

Take away block_hash, block_index duplicates processing script from migration to script as optional stuff since the probability of its necessity in migration is low but the time of execution is long. Thus, it is recommended to use it optionally if corresponding migration is failed due to {block_hash, block_index} pair duplicates.

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-take-away-dups-script-from-migration branch from 6571356 to a487969 Compare January 17, 2020 11:03
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Jan 17, 2020
@vbaranov vbaranov self-assigned this Jan 17, 2020
@coveralls
Copy link

coveralls commented Jan 17, 2020

Pull Request Test Coverage Report for Build 8be2c84d-9e89-45b7-a83b-dac746c9e420

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 75.248%

Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
Totals Coverage Status
Change from base Build 4eeb35fe-dba3-426d-a52e-8fa890531245: 0.01%
Covered Lines: 5378
Relevant Lines: 7147

💛 - Coveralls

@vbaranov vbaranov merged commit a4fc64a into master Jan 17, 2020
@vbaranov vbaranov deleted the vb-take-away-dups-script-from-migration branch January 17, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants