-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restart cache for tests #2906
restart cache for tests #2906
Conversation
on the first call address sum cache starts task to fetch a value from the DB and return nil
f5f4382
to
ddec341
Compare
Pull Request Test Coverage Report for Build c71f64ad-9fdd-4717-818a-548d8bfe5924
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayrat555 mox tests are in a failed state
0c4e1f9
to
9891476
Compare
9891476
to
bd46a30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayrat555 endpoint works very slow now: > 10 sec. It looks like it doesn't take data from cache but makes a query on DB on call, does it?
@vbaranov I just checked it. And it fetches from the db on the first call. All other calls use a cached value. It re-fetches value after |
@ayrat555 1 minute in my test. What is the problem to keep this endpoint async? This endpoint will be used by exchanges. And there will be downtime if it will be called at the time of cache updating. I urge to keep this endpoint async and fix tests for it instead of making it synchronous. I don't see the problem if it will return 0 on the first call. This is less painful than to have a synchronous endpoint, I think. |
@vbaranov I addressed your comment. Now this PR just fixes tests |
on the first call address sum cache starts a task to
fetch a value from the DB and return nil
Related commit b87fc2d
Changelog