-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend getsourcecode API view with new output fields #2857
Conversation
b9af04b
to
ef0a51c
Compare
ef0a51c
to
aeb17ff
Compare
Pull Request Test Coverage Report for Build 23f16034-99dc-4dfa-9a63-946ab8f3a244
💛 - Coveralls |
aeb17ff
to
b5bce41
Compare
"OptimizationRuns" => "", | ||
"EVMVersion" => "", | ||
"ConstructorArguments" => "", | ||
"ExternalLibraries" => "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no tests for ExternalLibraries
and ConstructorArguments
fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apps/block_scout_web/lib/block_scout_web/views/api/rpc/contract_view.ex
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one style comment. Otherwise, LGTM
b28c988
to
4ed9fdd
Compare
Closes #751
Motivation
getsourcecode
API endpoint doesn't return all fields Blockscout reserved for a smart-contracts in DBChangelog
Add the new fields to the view:
Configure hiding of output fields in the view if they are empty
Checklist for your Pull Request (PR)
CHANGELOG.md
with this PRmaster
in the Version column. Changes will be reflected in this table: https://docs.blockscout.com/for-developers/information-and-settings/env-variables.