-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autodetection of constructor arguments #2821
Conversation
Pull Request Test Coverage Report for Build 8f73d800-ee1d-43bf-bb9c-1b90dc01e448
💛 - Coveralls |
9bca115
to
ae8e162
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that Blockscout will show constructor arguments if it is chosen to retrieve them automatically. Anyway, UX suffers a little bit, imho.
Request for changes:
- If a user chooses to fetch contructor arguments automatically, the field
ABI-encoded Constructor Arguments ...
should be disabled - otherwise, it should be enabled
3.a. the best option would be to fetch and show constructor arguments immediately on enabling of automatic fetching
3.b. if you do not choose to retrieve them immediately for some reasons, I'd suggest to completely hide/show the fieldABI-encoded Constructor Arguments ...
when a user enables/disables auto fetching
@vbaranov I added hiding of constructor arguments field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayrat555 I tried to use auto-appending of arguments. It works incorrectly.
I deployed smart-contract to Sokol with on uint
constructor argument /address/0x3ee96c3a3a570de90602384d0d18e5cac06bf791/contracts
verified it locally with auto-appending flag. The input value for a single constructor argument was 2
, the contract was verified, but this is what I see in the Constructor arguments field of verified contract page. Obviously, the value is wrong:
dc5252b
to
3bdcf4d
Compare
resolves #2338
Changlelog: