Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url error in API page #2591

Merged
merged 20 commits into from
Aug 29, 2019
Merged

Fix url error in API page #2591

merged 20 commits into from
Aug 29, 2019

Conversation

saneery
Copy link
Contributor

@saneery saneery commented Aug 19, 2019

#2585

Motivation

There is a bug with the url on calling of API methods. JS code runs a query just to https://blockscout.com/api it should be with a full path like this https://blockscout.com/eth/mainnet/api

Checklist for your PR

@saneery saneery changed the title Fix error of url in API page Fix url error in API page Aug 19, 2019
@saneery saneery requested review from pasqu4le, vbaranov and ayrat555 and removed request for pasqu4le and vbaranov August 19, 2019 08:48
@coveralls
Copy link

coveralls commented Aug 19, 2019

Pull Request Test Coverage Report for Build ecc9718a-b232-41f3-b684-ca6246f3fdff

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 79.086%

Totals Coverage Status
Change from base Build 91cc4c90-1174-4126-86cb-ce14979529dd: 0.06%
Covered Lines: 5207
Relevant Lines: 6584

💛 - Coveralls

@saneery saneery requested a review from ayrat555 August 19, 2019 13:29
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curl -X POST --data '{"id":0,"jsonrpc":"2.0","method": "eth_getBalance", "params": []}'

Copy button copies it without double-quotes in params

@vbaranov vbaranov self-requested a review August 20, 2019 20:54
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saneery saneery requested a review from vbaranov August 21, 2019 10:02
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saneery

  1. protocol should be indicated

Screenshot 2019-08-24 at 12 27 57

  1. An example is not full - an endpoint is empty. It is a bad UX for users. They should be able to copy/paste the command to the terminal.

Screenshot 2019-08-24 at 12 27 42

@saneery saneery requested a review from vbaranov August 28, 2019 12:29
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saneery saneery requested a review from vbaranov August 29, 2019 07:43
@vbaranov vbaranov merged commit 516d67a into master Aug 29, 2019
@vbaranov vbaranov deleted the fix-api-try-out branch August 29, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants