-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix url error in API page #2591
Conversation
Pull Request Test Coverage Report for Build ecc9718a-b232-41f3-b684-ca6246f3fdff
💛 - Coveralls |
apps/block_scout_web/lib/block_scout_web/views/api_docs_view.ex
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curl -X POST --data '{"id":0,"jsonrpc":"2.0","method": "eth_getBalance", "params": []}'
Copy button copies it without double-quotes in params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- protocol should be indicated
- An example is not full - an endpoint is empty. It is a bad UX for users. They should be able to copy/paste the command to the terminal.
551d9ee
to
aabb006
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2585
Motivation
There is a bug with the url on calling of API methods. JS code runs a query just to
https://blockscout.com/api
it should be with a full path like thishttps://blockscout.com/eth/mainnet/api
Checklist for your PR
CHANGELOG.md
with this PRmaster
in theVersion
column.