Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix slash before not empty path in docs #2560

Merged
merged 4 commits into from
Aug 13, 2019
Merged

fix slash before not empty path in docs #2560

merged 4 commits into from
Aug 13, 2019

Conversation

ayrat555
Copy link
Contributor

Changelog

  • fix slash before not empty path in docs

pasqu4le
pasqu4le approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@pasqu4le pasqu4le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only advice is to drop the custom handle_slash function

@vbaranov vbaranov merged commit 7a352da into master Aug 13, 2019
@vbaranov vbaranov deleted the ab-fix-slash-with-not-empty-path branch August 13, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayrat555 @vbaranov @saneery @pasqu4le