Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide decoded row if event is not decoded #2492

Merged
merged 7 commits into from
Aug 6, 2019
Merged

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Aug 2, 2019

fixes #2476

Motivation

Some logs events can not be decoded because matching function is not found in the contract's abi.
For example https://blockscout.com/eth/mainnet/address/0x1c527e27aa092c566cdfcc537faf5acc74a62ea0/logs
the same is happening in etherscan https://etherscan.io/address/0x1C527e27aA092c566cdFCC537Faf5acC74A62Ea0#events

Changelog

  • hide decoded row if event is not decoded

@coveralls
Copy link

Pull Request Test Coverage Report for Build a5cfcadd-6573-4004-9980-7d409fda8c10

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 79.268%

Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/block/catchup/fetcher.ex 16 69.23%
Totals Coverage Status
Change from base Build 34a43d50-d2a8-4754-bcd6-df47fc2bb2c1: 0.003%
Covered Lines: 5154
Relevant Lines: 6502

💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 2, 2019

Pull Request Test Coverage Report for Build 3d31f9f5-d034-41de-901a-1ec59166bfaa

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 79.235%

Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
Totals Coverage Status
Change from base Build dc58b1b4-eac8-4e56-be99-113b83e614ee: 0.2%
Covered Lines: 5155
Relevant Lines: 6506

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2efe0fcd-5f79-4d54-bcad-814425739ea4

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 79.268%

Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/block/catchup/fetcher.ex 16 69.23%
Totals Coverage Status
Change from base Build 34a43d50-d2a8-4754-bcd6-df47fc2bb2c1: 0.003%
Covered Lines: 5154
Relevant Lines: 6502

💛 - Coveralls

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that hiding events is a good solution if we cannot decode it. A user should be able to see all events on contract. The issue is rather about how to increase the number of decoded events.

@ayrat555
Copy link
Contributor Author

ayrat555 commented Aug 5, 2019

@vbaranov we won't hide event. We'll only hide empty 'Decoded' row

@vbaranov vbaranov self-requested a review August 5, 2019 14:59
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got it. I incorrectly interpreted the PR's description w/out before/after screenshots.

@vbaranov vbaranov merged commit 2dbe359 into master Aug 6, 2019
@vbaranov vbaranov deleted the ab-hide-decoded-row branch August 6, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs decoding doesn't work for some types of logs
5 participants