-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hide decoded row if event is not decoded #2492
Conversation
Pull Request Test Coverage Report for Build a5cfcadd-6573-4004-9980-7d409fda8c10
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3d31f9f5-d034-41de-901a-1ec59166bfaa
💛 - Coveralls |
Pull Request Test Coverage Report for Build 2efe0fcd-5f79-4d54-bcad-814425739ea4
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that hiding events is a good solution if we cannot decode it. A user should be able to see all events on contract. The issue is rather about how to increase the number of decoded events.
@vbaranov we won't hide event. We'll only hide empty 'Decoded' row |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, got it. I incorrectly interpreted the PR's description w/out before/after screenshots.
fixes #2476
Motivation
Some logs events can not be decoded because matching function is not found in the contract's abi.
For example https://blockscout.com/eth/mainnet/address/0x1c527e27aa092c566cdfcc537faf5acc74a62ea0/logs
the same is happening in etherscan https://etherscan.io/address/0x1C527e27aA092c566cdFCC537Faf5acC74A62Ea0#events
Changelog