Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix top addresses query #2459

Merged
merged 6 commits into from
Jul 31, 2019
Merged

fix top addresses query #2459

merged 6 commits into from
Jul 31, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jul 29, 2019 •
edited
Loading

Pagination query for top addresses has wrong conditions which exclude some records.

fixes #2454

Changelog

  • fix top addresses query

@coveralls
Copy link

coveralls commented Jul 29, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 8b2b5de0-df80-4aee-af6c-36bdc5d3f86a

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.319%
Totals Coverage Status
Change from base Build 392cda83-d665-47aa-89a0-8a94226ff8c2: 0.0%
Covered Lines: 5151
Relevant Lines: 6494
💛 - Coveralls

vbaranov
vbaranov reviewed Jul 30, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555

why did you change condition here 397b452 ?

@ayrat555
Copy link
Contributor Author

ayrat555 commented Jul 30, 2019 •
edited
Loading

@ayrat555

why did you change condition here 397b452 ?

so two conditions (address.fetched_coin_balance == ^coin_balance and address.hash > ^hash) and
address.fetched_coin_balance < ^coin_balance won't intersect`

@vbaranov vbaranov self-requested a review July 30, 2019 10:59
@vbaranov vbaranov merged commit b6cf1b4 into master Jul 31, 2019
@vbaranov vbaranov deleted the ab-fix-top-addresses-query branch July 31, 2019 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MIssing accounts on the accounts page
5 participants
@ayrat555 @coveralls @vbaranov @saneery @pasqu4le