Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hiding of loader for txs on the main page #2421

Merged
merged 2 commits into from
Jul 25, 2019
Merged

Fix hiding of loader for txs on the main page #2421

merged 2 commits into from
Jul 25, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Jul 24, 2019 •
edited
Loading

This timeout was implemented here #2324 and was broken with a new type of loader #2405

Motivation

Fixing of hiding of loader for txs block on the main page if loading less then 1 min

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@vbaranov vbaranov force-pushed the vb-main-page-txs-loader-timeout-fix branch from a483e55 to 6183eac Compare July 24, 2019 11:38
@vbaranov vbaranov self-assigned this Jul 24, 2019
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Jul 24, 2019
@vbaranov vbaranov requested review from pasqu4le, saneery, ayrat555 and Heimdell and removed request for pasqu4le July 24, 2019 11:38
@coveralls
Copy link

coveralls commented Jul 24, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build c25c1d15-2d4d-418d-abde-9049d42fd635

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.459%
Totals Coverage Status
Change from base Build 62cf5e91-d0c8-4e59-9d44-a733b166f1fb: 0.0%
Covered Lines: 5145
Relevant Lines: 6475
💛 - Coveralls

@vbaranov vbaranov merged commit 1990db8 into master Jul 25, 2019
@vbaranov vbaranov deleted the vb-main-page-txs-loader-timeout-fix branch July 25, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayrat555 ayrat555 ayrat555 approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

@Heimdell Heimdell Awaiting requested review from Heimdell

Assignees

@vbaranov vbaranov

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vbaranov @coveralls @ayrat555 @saneery @pasqu4le