Improve Address controllers #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is yet another step in checking controllers for improvements. In particular this time Address controllers were checked and this (mostly refactoring) changes were made: - a few calls to `Explorer.Chain.hash_to_address` were modified to avoid useless preloads where possible - `Explorer.Chain.find_or_insert_address_from_hash` was modified for the very same reason, because it calls the previous function - `Explorer.Chain.address_to_logs` has been modified to have a more legible where clause - both `Explorer.Chain.hash_to_address` and `Explorer.Chain.token_from_address_hash` were modified to support `necessity_by_association_option`s for consistency
pasqu4le
force-pushed
the
pp-address-controllers-improvements
branch
from
6e3883e to
54a1010
Compare
Pull Request Test Coverage Report for Build c7b221ca-6698-4627-a520-b19b5e1b11f1
💛 - Coveralls |
ayrat555
approved these changes
Jul 8, 2019
vbaranov
approved these changes
Jul 8, 2019
pasqu4le
added a commit
that referenced
this pull request
Jul 19, 2019
pasqu4le
added a commit
that referenced
this pull request
Jul 19, 2019
pasqu4le
added a commit
that referenced
this pull request
Jul 19, 2019
vbaranov
pushed a commit
that referenced
this pull request
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is yet another step in checking controllers for improvements.
In particular this time Address controllers were checked and this (mostly refactoring) changes were made:
Changelog
Explorer.Chain.hash_to_addresswere modified to avoid useless preloads where possibleExplorer.Chain.find_or_insert_address_from_hashwas modified for the very same reason, because it calls the previous functionExplorer.Chain.address_to_logshas been modified to have a more legible where clauseExplorer.Chain.hash_to_addressandExplorer.Chain.token_from_address_hashwere modified to supportnecessity_by_association_options for consistencyThis is the complete list of the controllers that were analyzed for possible improvements:
AddressCoinBalanceByDayControllerAddressCoinBalanceControllerAddressContractControllerAddressContractVerificationControllerAddressControllerAddressDecompiledContractControllerAddressInternalTransactionControllerAddressLogsControllerAddressReadContractControllerAddressTokenBalanceControllerAddressTokenControllerAddressValidationControllerAPI.RPC.AddressControllerChecklist for your PR
CHANGELOG.mdwith this PR