Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more validator reward types for xDai #2169

Merged
merged 3 commits into from
Jun 17, 2019
Merged

Conversation

ayrat555
Copy link
Contributor

fixes

2019-06-14T07:34:24.194 application=indexer fetcher=block_catchup first_block_number=3390348 last_block_number=3390348 [error] ** (FunctionClauseError) no function clause matching in EthereumJSONRPC.Parity.FetchedBeneficiaries.get_address_type/2
    (ethereum_jsonrpc) lib/ethereum_jsonrpc/parity/fetched_beneficiaries.ex:172: EthereumJSONRPC.Parity.FetchedBeneficiaries.get_address_type("external", 5)
    (ethereum_jsonrpc) lib/ethereum_jsonrpc/parity/fetched_beneficiaries.ex:156: EthereumJSONRPC.Parity.FetchedBeneficiaries.trace_to_params_set/3
    (ethereum_jsonrpc) lib/ethereum_jsonrpc/parity/fetched_beneficiaries.ex:132: anonymous fn/3 in EthereumJSONRPC.Parity.FetchedBeneficiaries.traces_to_params_set/2
    (elixir) lib/enum.ex:3015: anonymous fn/3 in Enum.reduce/3
    (elixir) lib/stream.ex:1556: anonymous fn/3 in Enumerable.Stream.reduce/3
    (elixir) lib/stream.ex:1047: anonymous fn/3 in Stream.with_index/2
    (elixir) lib/enum.ex:3317: Enumerable.List.reduce/3
    (elixir) lib/stream.ex:1568: Enumerable.Stream.do_each/4


Retrying.

Changelog

  • add more validator reward types for xDai

@vbaranov vbaranov self-requested a review June 14, 2019 08:04
@coveralls
Copy link

coveralls commented Jun 14, 2019

Pull Request Test Coverage Report for Build f5d86590-f245-4825-898e-1e056370c2f4

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 80.663%

Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/fetcher/token.ex 1 78.57%
apps/indexer/lib/indexer/fetcher/token_balance.ex 2 87.1%
apps/indexer/lib/indexer/block/fetcher.ex 3 88.0%
Totals Coverage Status
Change from base Build be7d4c0a-8fbe-49ce-ae62-2e3ddf25e349: -0.1%
Covered Lines: 4893
Relevant Lines: 6066

💛 - Coveralls

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 changelog entry is missing

@ayrat555 ayrat555 requested review from zachdaniel and pasqu4le June 14, 2019 08:49
@@ -174,6 +174,12 @@ defmodule EthereumJSONRPC.Parity.FetchedBeneficiaries do
defp get_address_type(reward_type, index) when reward_type == "external" and index == 2, do: :validator
defp get_address_type(reward_type, index) when reward_type == "external" and index == 3, do: :validator
defp get_address_type(reward_type, index) when reward_type == "external" and index == 4, do: :validator
defp get_address_type(reward_type, index) when reward_type == "external" and index == 5, do: :validator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really important, but these could all be when reward_type == "external" and index in 0..10.

@vbaranov vbaranov merged commit 23a2719 into master Jun 17, 2019
@vbaranov vbaranov deleted the ab-add-new-validors branch June 17, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants