Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pending transaction count #2149

Merged
merged 4 commits into from
Jun 13, 2019
Merged

Conversation

ayrat555
Copy link
Contributor

Part of #1612

Most of the time pending transaction query won't even start to execute because the request is timeout out on Chain.pending_transaction_count() query. Moreover, it looks like pending_transaction_count variable is not used

Changelog

  • remove pending transaction count

@coveralls
Copy link

coveralls commented Jun 12, 2019

Pull Request Test Coverage Report for Build 75f57044-a9e0-4d12-b9a2-6b03c5175af4

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 80.715%

Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/fetcher/token.ex 1 78.57%
apps/indexer/lib/indexer/fetcher/token_balance.ex 2 87.1%
apps/indexer/lib/indexer/fetcher/internal_transaction.ex 3 58.62%
apps/indexer/lib/indexer/block/fetcher.ex 3 88.0%
Totals Coverage Status
Change from base Build 2e95c516-1e18-48e1-90e9-f00ed0466d7a: -0.1%
Covered Lines: 4901
Relevant Lines: 6072

💛 - Coveralls

@vbaranov vbaranov merged commit c45d953 into master Jun 13, 2019
@vbaranov vbaranov deleted the ab-remove-pending-transaction-count branch June 13, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants