-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use better queries for listLogs endpoint #2014
Conversation
aa41c99
to
41b7ae6
Compare
Pull Request Test Coverage Report for Build f0131f74-43d6-4030-bfe0-8af47db002df
💛 - Coveralls |
b453689
to
3011d65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please provide a live example to compare responses between prod/stg where this update gives benefit? Because of an example from the original issue still returns me 504 error on stg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I only have a couple of minor comments
cf323f7
to
c39b39b
Compare
c39b39b
to
2ccdfab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works much faster on stg 👍
#1858
Motivation
Changelog
Bug Fixes
Use a more optimized query when provided with an address hash filter. We first limit our search to logs from transactions and internal transactions that were from, to, or creating the provided address. This limits the search space significantly.
CHANGELOG.md
with this PRNote: The existing tests reinforce correct behavior, but I can't write a unit test to confirm the performance characteristics.