Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support https for wobserver polling #1992

Merged
merged 1 commit into from
May 22, 2019
Merged

fix: support https for wobserver polling #1992

merged 1 commit into from
May 22, 2019

Conversation

zachdaniel
Copy link
Contributor

@zachdaniel zachdaniel commented May 21, 2019

Motivation

  • Wobserver has been getting out of date and is unsupported. I forked the fork we were using into one that was under poanetwork's umbrella so that we can fix it later if need be.
  • This fixes an issue that caused wobserver to be unusable under https.
  • I also had to clone the wobserver repo, and decided to clone it under the poanetwork umbrella, so that it could be changed more in the future if necessary.

Changelog

Bug Fixes

  • Wobserver has a fallback to use polling instead of ws. The websockets are not working, but I was able to get the polling version to work with HTTPS, so this fixes the short term issue. We'd would prefer websockets to work, but I have yet to discover what is broken about them, and wobserver itself appears to be abandoned.
  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@coveralls
Copy link

Pull Request Test Coverage Report for Build 54452c6b-4b15-4f32-a066-ba7d218077fe

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 81.125%

Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/fetcher/token.ex 1 78.57%
apps/indexer/lib/indexer/fetcher/token_balance.ex 2 87.1%
apps/indexer/lib/indexer/block/fetcher.ex 3 87.84%
Totals Coverage Status
Change from base Build f7aae3de-f599-4210-9288-15269d2937b0: -0.1%
Covered Lines: 4715
Relevant Lines: 5812

💛 - Coveralls

vbaranov added a commit that referenced this pull request May 22, 2019
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works 👍. Tested against HTTPS on stg.

@vbaranov vbaranov merged commit bca711a into master May 22, 2019
@vbaranov vbaranov deleted the fix-wobserver-ws branch May 22, 2019 16:07
vbaranov pushed a commit that referenced this pull request May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants