Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add log index to transaction view #1975

Merged
merged 5 commits into from
May 20, 2019
Merged

add log index to transaction view #1975

merged 5 commits into from
May 20, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented May 17, 2019

if a transaction has a big number of logs it's not apparent which page of logs is requested. Also, log index is used for logs pagination

Changelog

  • add log index to transaction view

@ghost ghost assigned ayrat555 May 17, 2019
@ghost ghost added the in progress label May 17, 2019
@coveralls
Copy link

coveralls commented May 17, 2019

Pull Request Test Coverage Report for Build 6730a2eb-fa07-42bf-93ad-fec3efcc5b77

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 81.175%

Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/fetcher/token.ex 1 78.57%
apps/indexer/lib/indexer/fetcher/token_balance.ex 2 87.1%
apps/indexer/lib/indexer/block/fetcher.ex 3 87.84%
Totals Coverage Status
Change from base Build 17f65b6f-b33a-4dad-b400-ad1d5d8fd47d: -0.1%
Covered Lines: 4713
Relevant Lines: 5806

💛 - Coveralls

@zachdaniel
Copy link
Contributor

I realized after approving that this change should also be reflected in the rpc documentation in etherscan.ex

@vbaranov vbaranov merged commit d76ec90 into master May 20, 2019
@vbaranov vbaranov deleted the ab-add-index-to-logs branch May 20, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants