-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add fields for contract filter performance #1966
Conversation
8cdc73c
to
d1a4f76
Compare
Pull Request Test Coverage Report for Build 240d86fb-4f10-4437-8b44-89a58d69cd0b
💛 - Coveralls |
d1a4f76
to
4781505
Compare
69927ca
to
6fcaf81
Compare
apps/indexer/lib/indexer/temporary/mark_decompiled_and_verified_smart_contracts.ex
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of comments about testing. feel free to ignore them
c664260
to
5613799
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zachdaniel thanks for the fix. I've installed it to stg server.
I've tested it by preliminary have been deleting indices addresses_decompiled_index
, addresses_verified_index
and, at least, this endpoint became to work almost instantly with offset 50 - 90
. For example, /api?module=contract&action=listcontracts&offset=50&filter=4
. Though, it still returns "504 gateway timeout for the limit >= 100".
As it works even without those indices (though, with a small limit of entries in the response), I would suggest to remove them from PR, because of those indices tend to increase write time into addresses
table, thus increasing the number of connections to DB.
5e83e71
to
0968cbd
Compare
@vbaranov Alright, I removed the temporary fetcher from this PR, so that it can safely be merged. I also double checked, and the data is fully migrated. There are no decompiled_smart_contracts that aren't marked as |
9a355c9
to
9cb3c94
Compare
9cb3c94
to
465af2f
Compare
465af2f
to
d2336bc
Compare
Resolves #1951
Changelog
Bug Fixes
Incompatible Changes
Checklist for your PR
CHANGELOG.md
with this PR