Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Chore) Divide chains by Mainnet/Testnet in menu #1804

Merged
merged 4 commits into from
Apr 22, 2019
Merged

(Chore) Divide chains by Mainnet/Testnet in menu #1804

merged 4 commits into from
Apr 22, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Apr 22, 2019 •
edited
Loading

Fixes #1752

Motivation

Chaos in chains menu

Changelog

Enhancements

Screenshot 2019-04-22 at 17 58 40

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@ghost ghost assigned vbaranov Apr 22, 2019
@ghost ghost added the in progress label Apr 22, 2019
@vbaranov vbaranov changed the title Divide chains by Mainnet/Testnet in menu (Chore) Divide chains by Mainnet/Testnet in menu Apr 22, 2019
@vbaranov vbaranov added ready for review This PR is ready for reviews. and removed in progress labels Apr 22, 2019
@ghost ghost added the in progress label Apr 22, 2019
@coveralls
Copy link

coveralls commented Apr 22, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 8fbe17c7-6b4b-4d11-b342-120f304d956b

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 82.387%
Totals Coverage Status
Change from base Build b2ffda17-a22d-4bc4-966c-ba58596880d2: 0.1%
Covered Lines: 4439
Relevant Lines: 5388
💛 - Coveralls

@vbaranov vbaranov merged commit a63edc5 into master Apr 22, 2019
@vbaranov vbaranov deleted the update-chains-menu branch April 22, 2019 15:20
@ghost ghost removed the in progress label Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodsoft goodsoft goodsoft approved these changes

@zachdaniel zachdaniel zachdaniel approved these changes

@ayrat555 ayrat555 Awaiting requested review from ayrat555

Assignees

@vbaranov vbaranov

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit dropdown list for Networks
4 participants
@vbaranov @coveralls @goodsoft @zachdaniel