Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix first block parameter #1768

Merged
merged 3 commits into from
Apr 18, 2019
Merged

fix first block parameter #1768

merged 3 commits into from
Apr 18, 2019

Conversation

ayrat555
Copy link
Contributor

fixes #1767

Changelog

  • fix first block parameter

@ghost ghost assigned ayrat555 Apr 17, 2019
@ghost ghost added the in progress label Apr 17, 2019
@coveralls
Copy link

coveralls commented Apr 17, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build ffe891f1-3560-4195-b5cf-0a81cb48f046

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 83.083%
Totals Coverage Status
Change from base Build cdd4b073-0bd9-4ec0-8ecd-35e264146685: 0.01%
Covered Lines: 4425
Relevant Lines: 5326
💛 - Coveralls

vbaranov
vbaranov approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, we can generalize last_block() function as it only converts an integer to string to smth like parse_int(input)? Anyways, I'm ok with the current implementation.

@ayrat555 ayrat555 merged commit e37fd92 into master Apr 18, 2019
@ayrat555 ayrat555 deleted the ab-fix-first-block-parameter branch April 18, 2019 13:50
@ghost ghost removed the in progress label Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodsoft goodsoft goodsoft approved these changes

@vbaranov vbaranov vbaranov approved these changes

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees

@ayrat555 ayrat555

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FIRST_BLOCK env can't be used
5 participants
@ayrat555 @coveralls @goodsoft @vbaranov @zachdaniel