Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/query: Data races #4295

Closed
metalmatze opened this issue Jan 30, 2024 · 0 comments
Closed

pkg/query: Data races #4295

metalmatze opened this issue Jan 30, 2024 · 0 comments

Comments

@metalmatze
Copy link
Member

CI runs fail to run make test ENABLE_RACE=yes due to race conditions.
Our CI doesn't always catch this, but I can consistently reproduce it on a beefier machine locally.
go test -race -tags assert -v ./pkg/query scopes to test the specific package.

It seems to already have been on https://github.com/parca-dev/parca/releases/tag/v0.20.0; however, not on https://github.com/parca-dev/parca/releases/tag/v0.19.0.

git bisect said it was this commit that broke things: 44bc42e
That is quite odd as this commit only ran buf generate.

I need more time to investigate when this started happening and then find out why.
If you have an idea, feel free to share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant