Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message when no library targets are found #723

Closed
sajis997 opened this issue Mar 29, 2024 Discussed in #722 · 1 comment · Fixed by #741
Closed

Improve error message when no library targets are found #723

sajis997 opened this issue Mar 29, 2024 Discussed in #722 · 1 comment · Fixed by #741
Labels
A-cli Area: engine around the lints C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.

Comments

@sajis997
Copy link

Discussed in #722

Originally posted by sajis997 March 29, 2024
usiing the following in the pipeline

- name: Check semver
  uses: obi1kenobi/cargo-semver-checks-action@v2

I am getting the following error:

error: no crates with library targets selected, nothing to semver-check
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
@obi1kenobi obi1kenobi changed the title fails in GitHub Actions Improve error message when no library targets are found Mar 29, 2024
@obi1kenobi
Copy link
Owner

We can probably make the error message a bit better here. For example:

error: no crates with library targets selected, nothing to semver-check
note: only library targets contain an API surface that can be checked for semver
note: skipped crates foo, bar, baz since they do not have a library target

@obi1kenobi obi1kenobi added A-cli Area: engine around the lints C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue. labels Mar 29, 2024
@obi1kenobi obi1kenobi mentioned this issue Apr 11, 2024
Open
@jw013 jw013 mentioned this issue Apr 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cli Area: engine around the lints C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add more detailed message when no library targets found. jw013/cargo-semver-checks
2 participants
@obi1kenobi @sajis997