Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): revert #2600 to fix excessive column data slot re-renders #3375

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

coreyshuman
Copy link

πŸ”— Linked issue

Resolves #3367

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This reverts commit b23f2de.

Release v2.20.0 includes PR #2600 which re-renders every table column data slot on any changes to the table source data. This introduces significant performance impact on large tables and makes it difficult for users to interact with inputs within tables since the re-render will lose cursor position. This also makes it impossible to tab between columns when data changes. This change was attempting to fix an issue which is unrelated to the Table component as demonstrate in #2004 (comment). This PR reverts those changes, returning Table data slot behavior to v2.19.1.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac benjamincanac changed the title fix(Table): Revert #2600 to fix excessive column data slot re-renders fix(Table): revert #2600 to fix excessive column data slot re-renders Mar 8, 2025
@benjamincanac benjamincanac merged commit 23d9b51 into nuxt:dev Mar 8, 2025
2 checks passed
@benjamincanac
Copy link
Member

Thanks! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants