Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn install better-sqlite3 build fails under Node.js 23.6.0 #591

Closed
MikeMcC399 opened this issue Jan 13, 2025 · 5 comments
Closed

yarn install better-sqlite3 build fails under Node.js 23.6.0 #591

MikeMcC399 opened this issue Jan 13, 2025 · 5 comments

Comments

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Jan 13, 2025

Issue

yarn install fails under Node.js 23.6.0 ("Current" version, released Oct 15, 2024)

better-sqlite3@npm:10.1.0 couldn't be built successfully

Attempting to update .github/workflows/ci.yml to run also on Node.js 23 shows that it fails under ubuntu-latest, macos-latest and windows-latest.

Following the instructions in CONTRIBUTING locally and running yarn install in Ubuntu 24.04.1 LTS reproduces the failure also.

Logs

Run corepack yarn install --immutable
➤ YN0000: · Yarn 4.3.1
➤ YN0000: ┌ Resolution step
Resolution step
➤ YN0000: └ Completed
➤ YN0000: ┌ Post-resolution validation
Post-resolution validation
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
Fetch step
➤ YN0000: └ Completed in 2s 582ms
➤ YN0000: ┌ Link step
Link step
➤ YN0009: better-sqlite3@npm:10.1.0 couldn't be built successfully (exit code 1, logs can be found here: /tmp/xfs-7c8502a7/build.log)
/tmp/xfs-7c8502a7/build.log
➤ YN0000: └ Completed in 1m 11s
➤ YN0000: · Failed with errors in 1m 14s
Error: Process completed with exit code 1.

@arcanis
Copy link
Contributor

arcanis commented Jan 13, 2025

This isn't related to Corepack. The issue likely comes from better-sqlite3 itself, although it's difficult to say since you didn't paste the log file described in the output.

@arcanis arcanis closed this as not planned Won't fix, can't repro, duplicate, stale Jan 13, 2025
@MikeMcC399
Copy link
Contributor Author

@arcanis

This isn't related to Corepack. The issue likely comes from better-sqlite3 itself, although it's difficult to say since you didn't paste the log file described in the output.

The issue appears to be due to an older version of better-sqlite3 which corepack is configured to use. If you would like to re-open this issue I can propose some changes to the corepack configuration which would resolve the issue. (Basically drop Node.js 21 support and upgrade better-sqlite3).

@MikeMcC399
Copy link
Contributor Author

The suggestion seems to work. See https://github.com/MikeMcC399/corepack/actions/runs/12744446123 for test run.

@MikeMcC399
Copy link
Contributor Author

@MikeMcC399
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants