Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show Inspector tabs that don't pertain to a selected object #7959

Open
charlesh88 opened this issue Dec 11, 2024 · 2 comments
Open

Don't show Inspector tabs that don't pertain to a selected object #7959

charlesh88 opened this issue Dec 11, 2024 · 2 comments
Assignees

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Dec 11, 2024

Is your feature request related to a problem? Please describe.
Many sub-objects of views, when clicked, invoke Inspector tabs (like the Styles tab) that don't pertain to them, such as Time Strip swimlanes and their sub-objects.

Describe the solution you'd like
Selectable objects and sub-objects should have a method to disallow "standard" Inspector tabs that don't pertain to them.

This feature is required for #7936

@charlesh88
Copy link
Contributor Author

charlesh88 commented Jan 14, 2025

Detailed matrix of desired tab visibility is here. High-level summary:

  1. Only show Annotations tabs for views and sub-views that can be annotated, and don't show at all in edit mode.
  2. Don't show Styles tab in browse mode. @jvigliotta says we can implement this in the Styles Inspector tab view provider.
  3. Show the Elements pool in read-only mode in browse mode for those views that have it.
  4. Generally, Properties is P1 in browse mode except for Plan Activities and Notebook Entries. In edit mode, Config is P1 for views that have it, followed by Elements and then Styles. Properties is always last priority in this mode.

@jvigliotta
Copy link
Contributor

jvigliotta commented Feb 21, 2025

Inspector Tab Tests

Use this text matrix to verifiy the correct inspector tabs are shown (and in the correct order) for each view type in both Browse and Edit modes.

Basic Views

Clock
Browse: Properties

Folder
Browse: Properties

Hyperlink
Browse: Properties

Notebook
Browse: Properties

Timer
Browse: Properties

Generator Views

Event Message Generator
Browse: Properties

Event Message Generator with Acknowledge
Browse: Properties

Sine Wave Generator
Browse: Properties, Annotations

Plot Views

Graph
Browse: Properties, Config, Elements, Styles
Edit: Config, Elements, Styles, Properties

Overlay Plot
Browse: Properties, Config, Annotations, Styles
Edit: Config, Elements, Styles, Filters, Properties

Scatter Plot
Browse: Properties, Config, Elements, Styles
Edit: Config, Elements, Styles, Properties

Stacked Plot
Browse: Properties, Config, Annotations, Elements, Styles
Edit: Config, Elements, Styles, Properties

Layout Views

Display Layout
Browse: Properties, Elements, Styles
Edit: Elements, Styles, Properties

Flexible Layout
Browse: Properties, Elements, Styles
Edit: Elements, Styles, Properties

Tabs View
Browse: Properties, Elements, Styles
Edit: Elements, Styles, Properties

Table Views

LAD Table
Browse: Properties, Config, Elements, Styles
Edit: Config, Elements, Styles, Properties

LAD Table Set
Browse: Properties, Config, Elements, Styles
Edit: Config, Elements, Styles, Properties

Telemetry Table
Browse: Properties, Config, Elements, Styles
Edit: Config, Elements, Styles, Filters, Properties

Time List
Browse: Properties, Config, Elements
Edit: Config, Elements, Properties

Other Visualization Views

Condition Set
Browse: Properties, Elements, Annotations
Edit: Elements, Properties

Condition Widget
Browse: Properties, Styles
Edit: Styles, Properties

Example Imagery
Browse: Properties, Annotations

Gantt Chart
Browse: Properties, Config, Elements
Edit: Config, Elements, Properties

Gauge
Browse: Properties, Elements, Styles
Edit: Elements, Styles, Properties

Time Strip
Browse: Properties, Elements
Edit: Elements, Properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants