Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition Manager is using older telemetry API and conditional styling can use a performance upgrade #7840

Closed
3 of 7 tasks
jvigliotta opened this issue Sep 12, 2024 · 1 comment · Fixed by #7841
Closed
3 of 7 tasks
Labels
type:bug verified Tested or intentionally closed

Comments

@jvigliotta
Copy link
Contributor

Summary

This came about when debugging VIPERGC-550, in which a conditionally styled alphanumeric in a display layout was showing the wrong styles being applied. Testing showed there are situations where conditional styling could be applied incorrectly. This lead to performance enhancements to how the styles are applied and discovering a mismatch in how telemetry is requested in ConditionManager.

Expected vs Current Behavior

Applying styles can happen quickly and change often, it should be performant. ConditionManager should use the newer TelemetryCollections in the telemetry API to request telemetry.

Steps to Reproduce

  1. Create a condition on a moderately fast changing endpoint
  2. Use that endpoint to style an alphanumeric in a display layout
  3. Note that styles can be applied incorrectly

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

In the below video, the item should only be red, when the value is above 100 (that is not happening consistently).
https://github.com/user-attachments/assets/4fa2f7cf-c821-461d-9a30-d1430764900d

@unlikelyzero unlikelyzero added this to the Target:4.1.0 milestone Sep 13, 2024
@ozyx ozyx closed this as completed in #7841 Oct 2, 2024
@akhenry akhenry modified the milestones: Target:4.1.0, Build 9 RC11 Oct 2, 2024
@akhenry
Copy link
Contributor

akhenry commented Oct 2, 2024

Verified Fixed.

In the video below the fixed code is in the left window, the pre-fix code is on the right. At about the 12 second mark the pre-fix code condition set shows > 100 even though the underlying value is 65. The Note that the data are being fed from different data sources, so the data are expected to be different.

Screen.Recording.2024-10-02.at.3.49.30.PM.mov

@akhenry akhenry added the verified Tested or intentionally closed label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug verified Tested or intentionally closed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants