Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Finalize playwright-eslint work #7797

Closed
ozyx opened this issue Jul 31, 2024 · 3 comments · Fixed by #7581
Closed

[e2e] Finalize playwright-eslint work #7797

ozyx opened this issue Jul 31, 2024 · 3 comments · Fixed by #7581
Labels
type:maintenance tests, chores, or project maintenance verified Tested or intentionally closed

Comments

@ozyx
Copy link
Contributor

ozyx commented Jul 31, 2024

Summary

  • Remove force: true from click actions in e2e to the greatest extent possible
    • Document wherever it's not possible, and why
  • baseFixtures and appActions
    • Review code in appActions and try to update the locators to be modern as best as we can
  • No more test changes
@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Jul 31, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Jul 31, 2024
@ozyx ozyx self-assigned this Jul 31, 2024
@ozyx ozyx closed this as completed in #7581 Aug 7, 2024
@akhenry
Copy link
Contributor

akhenry commented Oct 2, 2024

Needs test instructions

@akhenry akhenry modified the milestones: Target:4.0.0, Build 9 RC11 Oct 2, 2024
@ozyx
Copy link
Contributor Author

ozyx commented Oct 2, 2024

The main functional code this touches is removing a nextTick() before we resize the compass component on an image view.

Testing Instructions

  1. Create an example imagery view
  2. Navigate to it
  3. Ensure the compass appears correctly
  4. Resize the window. Ensure the compass behaves properly
  5. Create a display layout
  6. Drag the imagery view into the layout
  7. Resize it in the layout and verify that it resizes properly
  8. Create a timelist
  9. Drag the example imagery into the timelist
  10. Verify that the compass appears (or doesn't appear) where it should be

@unlikelyzero
Copy link
Contributor

Followed TO THE BEST OF MY ability reading these GARAGIO instructions

@unlikelyzero unlikelyzero added the verified Tested or intentionally closed label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance verified Tested or intentionally closed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants