Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Recent Objects] Add a collapse button to Recents #7491

Closed
7 tasks
rukmini-bose opened this issue Feb 9, 2024 · 3 comments
Closed
7 tasks

[Recent Objects] Add a collapse button to Recents #7491

rukmini-bose opened this issue Feb 9, 2024 · 3 comments
Labels
type:enhancement verified Tested or intentionally closed
Milestone

Comments

@rukmini-bose
Copy link
Contributor

rukmini-bose commented Feb 9, 2024

Summary

Recent Objects needs a horizontal collapse bar, similar to what we have for the Object Tree and Inspector. This will give us the ability to collapse and hide Recent Objects if it is not needed by a a user. Additionally, a collapse button will help with our mobile user experience improvements. That mobile issue can be found here: #7318

Currently, the only capability we have is the ability to drag to resize Recents on Desktop. What we want is the ability for a "minimize" button next to the Recent Objects header. Clicking this will automatically drop the vertical height of the pane. This is a quick example of what we want:
Screenshot 2024-02-08 at 4 49 58 PM Screenshot 2024-02-08 at 4 50 09 PM

For more information on design and behavior, talk to @rukmini-bose.

Expected vs Current Behavior

Steps to Reproduce

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@rukmini-bose rukmini-bose added type:bug type:enhancement not_viper Temporary label to define bugs that won't affect viper deployments and removed type:bug labels Feb 9, 2024
@unlikelyzero
Copy link
Contributor

@rukmini-bose when implementing this, you'll need to make this title and aria-label distinct from the other collapse buttons for inspector and tree

@rukmini-bose
Copy link
Contributor Author

Testing Instructions:

  1. Open the Object Tree and verify that Recent Objects is open by default.
  2. Check that a new collapse button has been added to the Recent Objects. The button looks the same as the collapse pane buttons that are used for the Object Tree and Inspector
  3. Click the button and verfiy that the Recent Objects pane collapses down vertically to become a very small pane, in which only " + Recently Viewed" is visible.
  4. Click the collapsed pane, and verify that the Recent Objects pane expands upwards again.
  5. Resize the Recent Objects pane vertically, and then repeat steps 3 and 4 and make sure that the pane retains the same height as before.

@ozyx ozyx closed this as completed Feb 27, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Feb 27, 2024
@unlikelyzero unlikelyzero removed the not_viper Temporary label to define bugs that won't affect viper deployments label Feb 27, 2024
@ozyx
Copy link
Contributor

ozyx commented Mar 5, 2024

Verified -- Testathon 3/5/24

Fantastic work.

@ozyx ozyx added the verified Tested or intentionally closed label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement verified Tested or intentionally closed
Projects
None yet
Development

No branches or pull requests

3 participants