Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabs should default to not load eagerly #7198

Closed
davetsay opened this issue Nov 2, 2023 · 2 comments · Fixed by #7199
Closed

tabs should default to not load eagerly #7198

davetsay opened this issue Nov 2, 2023 · 2 comments · Fixed by #7199
Labels
notable_change A change which should be noted in the changelog performance impacts or improves performance type:enhancement verified Tested or intentionally closed
Milestone

Comments

@davetsay
Copy link
Contributor

davetsay commented Nov 2, 2023

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@scottbell
Copy link
Contributor

scottbell commented Jan 11, 2024

To test:

  1. Create a tabs object. The resultant form should have the eager tabs toggle switched off:
after-default-false
  1. Change the index.html to install the plugin using the option to enable eager loading to default to true:
openmct.install(openmct.plugins.Tabs({ eagerLoad: true }));
  1. Create a tabs object. The resultant form should have the eager tabs toggle switched on:
after-default-true
  1. Generally test tab eager loading by creating two SWGs to drop onto the tabs object. When eager loading is turned on, on page load, both tabs object should have their component HTML loaded:
Eager-tabs-on

When eager loading is turned off, only the selected tab on page load should have its component HTML loaded:
Eager-tabs-off

  1. Repeat with real telemetry

@unlikelyzero unlikelyzero added this to the Target:4.0.0 milestone Jan 17, 2024
@unlikelyzero unlikelyzero added the performance impacts or improves performance label Jan 17, 2024
@unlikelyzero unlikelyzero added the notable_change A change which should be noted in the changelog label Feb 2, 2024
@ozyx
Copy link
Contributor

ozyx commented Feb 5, 2024

Verified Testathon 2/5/24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notable_change A change which should be noted in the changelog performance impacts or improves performance type:enhancement verified Tested or intentionally closed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants