Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Time List view] Time List should not "auto-center" #7167

Closed
charlesh88 opened this issue Oct 23, 2023 · 5 comments
Closed

[Time List view] Time List should not "auto-center" #7167

charlesh88 opened this issue Oct 23, 2023 · 5 comments
Labels
type:enhancement verified Tested or intentionally closed
Milestone

Comments

@charlesh88
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

When the Time List view is displaying a number of current events, it will continually try to vertically "auto-center" the display. This can have the result of hiding current events at the top of the list:

Screen Shot 2023-10-18 at 9 59 49 AM

Describe the solution you'd like
Change the "centering on now" approach to this algorithm:

  1. Show as many current and/or future events as possible, without scrolling any of either type beyond the top of the view area.
  2. Only show past events if all other current and future events can be displayed.
  3. If there are no past events in the current data set, then the centering algorithm could be turned off for efficiency.

image

This would be at the expense of scrolling past items beyond the top of the view when necessary.

@charlesh88 charlesh88 changed the title [Time List view] Time List should not "auto-center" if no past events are in view [Time List view] Time List should not "auto-center" Oct 23, 2023
@shefalijoshi shefalijoshi added this to the Target:3.2.1 milestone Nov 1, 2023
@shefalijoshi
Copy link
Contributor

Testing instructions:
See above screenshots.
Current and Future activities should always be scrolled into view first
If there is room left over after displaying ALL current and future activities, then only a subset of past activities should be displayed.
If all activities are viewable in the current view then no auto scrolling should occur.
If there are no past activities, there should be no auto scrolling at all.

@unlikelyzero unlikelyzero modified the milestones: Target:3.2.1, Target:3.3.0 Nov 13, 2023
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:4.0.0 Jan 17, 2024
@shefalijoshi
Copy link
Contributor

Should be fixed by #7194

@shefalijoshi shefalijoshi modified the milestones: Target:4.0.0, Target:3.3.0 Jan 17, 2024
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:4.0.0 Jan 17, 2024
@davetsay
Copy link
Contributor

verified

@charlesh88
Copy link
Contributor Author

charlesh88 commented Jan 31, 2024

Testathon 2024-01-31: verified NOT fixed. At some viewport heights, the compact Time List view will still auto-scroll in a way that hides a current Activity. Using the sim-9_025 plan:

Desired: Note current Activity at top in view:

Screenshot 2024-01-31 at 2 49 08 PM

Not desired: When auto-scrolled, top current Activity is now hidden:

Screenshot 2024-01-31 at 2 49 15 PM

Details for this are captured in #7449.

@unlikelyzero
Copy link
Contributor

Won't fix and do #7449

@unlikelyzero unlikelyzero closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2024
@unlikelyzero unlikelyzero added invalid duplicate or incorrectly filed verified Tested or intentionally closed and removed invalid duplicate or incorrectly filed labels Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement verified Tested or intentionally closed
Projects
None yet
Development

No branches or pull requests

4 participants