Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Update docker login step to work across forks and non-nasa-users #6890

Closed
unlikelyzero opened this issue Aug 4, 2023 · 2 comments · Fixed by #6891
Closed

[CI] Update docker login step to work across forks and non-nasa-users #6890

unlikelyzero opened this issue Aug 4, 2023 · 2 comments · Fixed by #6891
Labels
type:maintenance tests, chores, or project maintenance
Milestone
Target:3.1.0

Comments

@unlikelyzero
Copy link
Contributor

Summary

Current if a user creates a PR, the couchdb docker login step will fail due to restricted access to username/password

   - name: Login to DockerHub
        uses: docker/login-action@v2 
        with:
          username: ${{ secrets.DOCKERHUB_USERNAME }}
          password: ${{ secrets.DOCKERHUB_TOKEN }}
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Aug 4, 2023
@unlikelyzero unlikelyzero mentioned this issue Aug 4, 2023
Merged
15 tasks
@unlikelyzero unlikelyzero added this to the Target:3.1.0 milestone Aug 4, 2023
@unlikelyzero
Copy link
Contributor Author

Testing Notes

  • Create a fork of NASA Open MCT
  • Open PR against master
  • Verify that e2e-couchdb passes

@unlikelyzero unlikelyzero mentioned this issue Aug 5, 2023
Merged
15 tasks
@khalidadil
Copy link
Contributor

Created a fork and a PR against master, looks like e2e-couchdb passes so lgtm! Verified during testathon on 09/12/23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target:3.1.0
Development

Successfully merging a pull request may close this issue.

[CI] Update docker login step to work across forks and non-nasa-users nasa/openmct
2 participants
@khalidadil @unlikelyzero