Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress deprecation warnings in production mode #6870

Closed
akhenry opened this issue Aug 1, 2023 · 2 comments · Fixed by #6875
Closed

Suppress deprecation warnings in production mode #6870

akhenry opened this issue Aug 1, 2023 · 2 comments · Fixed by #6875
Assignees
Labels
severity:blocker type:maintenance tests, chores, or project maintenance
Milestone

Comments

@akhenry
Copy link
Contributor

akhenry commented Aug 1, 2023

Summary

Our Time API is currently issuing a very large number of deprecation warnings for commonly used functions such as .timesystem(). For complex displays this can result in 700+ warning messages. These should be suppressed in production mode.

@akhenry akhenry added the type:maintenance tests, chores, or project maintenance label Aug 1, 2023
@akhenry akhenry added this to the Target:3.0.0 milestone Aug 1, 2023
@ozyx ozyx self-assigned this Aug 1, 2023
@ozyx
Copy link
Contributor

ozyx commented Aug 2, 2023

Testing Instructions

  1. Create a Telemetry Table
  2. Add some telemetry to it
  3. Navigate to it, see in the console a warning about timeSystem deprecation
  4. Nav away and back, no more warnings about that specific method should be produced
  5. Repeat the same for other components that still use the old TimeAPI methods and verify that the same warning never appears more than once.

@shefalijoshi
Copy link
Contributor

Verified fixed.
I only saw repeated messages when in realtime mode when Imagery updates happened in a Display Layout

@akhenry akhenry removed the unverified label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:blocker type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants