Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role attribution to notebook entries #6664

Closed
akhenry opened this issue May 15, 2023 · 4 comments
Closed

Add role attribution to notebook entries #6664

akhenry opened this issue May 15, 2023 · 4 comments
Labels
type:feature Feature. Required intentional design
Milestone

Comments

@akhenry
Copy link
Contributor

akhenry commented May 15, 2023

Is your feature request related to a problem? Please describe.
Notebook entries include the user who created the entry. Users may have more than one role, so it would be useful to also include the user's active role at the time they created the notebook entry

@jvigliotta
Copy link
Contributor

@michaelrogers michaelrogers self-assigned this May 22, 2023
@unlikelyzero unlikelyzero added type:feature Feature. Required intentional design and removed type:enhancement labels Jun 2, 2023
@michaelrogers
Copy link
Contributor

How To Test

With user provider

  1. Navigate to / create a notebook
  2. Add a new entry
  3. Observe that the new entry contains username: role
  4. Change role and create a separate entry
  5. Observe that changed role is captured on entry

Note: any existing entries prior to this feature will not have the role saved

Without user provider

General smoke testing around notebook entries

Notebook text export

  1. Navigate to / create a notebook
  2. Add sufficient number of entries (both created/modified by different users/roles)
  3. Export Notebook as Text
  4. Observe that the Created at and Modified lines include the user's active role when possible

@ozyx
Copy link
Contributor

ozyx commented Jul 18, 2023

Testathon 7/18/23:

Verified! Adding an entry shows the username and current role. Switching roles and adding an entry shows the new role. Export as JSON / Export as Text preserves username and role.

Caveats (general):

  • Viewer role still shows "CHANGE ROLE" button but does nothing
  • The entries always show the role of the person that created the entry, but no info about who last modified the entry. More of an open question for @charlesh88

@unlikelyzero
Copy link
Contributor

@ozyx please file those as two issues an remove the unverified label

@ozyx ozyx removed the unverified label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature Feature. Required intentional design
Projects
None yet
Development

No branches or pull requests

5 participants