Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e] Re-enable snapshot tests #6267

Closed
unlikelyzero opened this issue Feb 2, 2023 · 1 comment · Fixed by #6271
Closed

[e2e] Re-enable snapshot tests #6267

unlikelyzero opened this issue Feb 2, 2023 · 1 comment · Fixed by #6271
Assignees
@ozyx
Labels
type:maintenance tests, chores, or project maintenance
Milestone
Target:2.1.6

Comments

@unlikelyzero
Copy link
Contributor

Summary

Now that #6159 has been addressed, we should be able to re-enable snapshot tests for overlay plots
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Feb 2, 2023
@unlikelyzero unlikelyzero added this to the Target:2.1.6 milestone Feb 2, 2023
@ozyx
Copy link
Contributor

ozyx commented Feb 2, 2023

root cause identified: #6159 (comment)

we will need to update our snapshots and re-enable the test

@ozyx ozyx mentioned this issue Feb 2, 2023
Merged
15 tasks
@ozyx ozyx closed this as completed in #6271 Feb 2, 2023
@ozyx ozyx mentioned this issue Feb 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ozyx ozyx

Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target:2.1.6
Development

Successfully merging a pull request may close this issue.

fix: remove 1px padding and re-enable autoscale snapshot test nasa/openmct
2 participants
@ozyx @unlikelyzero