Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating multiple notifications at the same time causes duplicated keys error #6242

Closed
1 of 7 tasks
marcelo-earth opened this issue Feb 1, 2023 · 2 comments · Fixed by #6243
Closed
1 of 7 tasks

Comments

@marcelo-earth
Copy link
Contributor

Summary

If two or more notifications are created at the same time, the same timestamp is assigned to the identifiers of the notification. This will cause the error of "Duplicated keys" from Vue.

src/plugins/notificationIndicator/components/NotificationsList.vue

 <notification-message
  :key="notification.model.timestamp"

While I'm not aware of a current situation where two notifications are created at the same time, this is one possible behavior that could occur. It also prevents creating two notifications using OpenMCT API without the tests failing.

Expected vs Current Behavior

Creating multiple notifications with the same time should not cause a Vue error of 'Duplicated keys'.

Steps to Reproduce

You can also check the video of the 'Additional Information' section of this issue.

  1. Try to create two notifications using the OpenMCT API
openmct.notifications.error("Error message 1");
openmct.notifications.error("Error message 2");
  1. Click on "2 Notifications" button
  2. Check error in console.

Environment

  • Open MCT Version: 2.1.6-SNAPSHOT
  • Deployment Type: Dev
  • OS: Mac OS
  • Browser: Google Chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

Reproduction of the error:

Screen.Recording.2023-01-31.at.10.41.16.PM.mov

Error when trying to run tests creating multiple notifications:

image

@ozyx
Copy link
Contributor

ozyx commented Mar 14, 2023

Verified Fixed - Testathon 3-14-2023 🥧

@michaelrogers
Copy link
Contributor

Fix verified during testathon 03/14/2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants