-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search] Increase the debounce timeout on search #6179
Milestone
Comments
Classifying as critical due to performance implications. |
15 tasks
Testing NotesThis will need to be tested 3 ways: local, VPN, and on Localstorage
VPN /testathonTest 1
Test 2
Test 3
Lab Testing@unlikelyzero will execute |
Verified fixed. Can confirm that joy was sparked. |
Found a separate issue with search and filed a followup - akhenry/openmct-yamcs#288 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Search debounce is a little aggressive right now and results in multiple requests being fired off even when I am typing quite quickly. This results in a lot of unnecessary hits on back-end services, and slows down the UI.
eg.
Typing the word "notebook" into the search input results in a request for every single letter that I type in. Many of them are cancelled, however not all.
Describe the solution you'd like
We should debounce user input at a much slower rate than we currently are to reduce backend requests.
On this topic, I am curious about what happens when results arrive out of order (eg a search for
n
might take a lot longer to return than a search fornotebook
. Some investigation should be performed to ensure we are only ever showing the most recent search results.The text was updated successfully, but these errors were encountered: