Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigating to an object from a Breadcrumb doesn't update the URL hash #6151

Closed
3 of 7 tasks
ozyx opened this issue Jan 20, 2023 · 4 comments · Fixed by #6234
Closed
3 of 7 tasks

Navigating to an object from a Breadcrumb doesn't update the URL hash #6151

ozyx opened this issue Jan 20, 2023 · 4 comments · Fixed by #6234

Comments

@ozyx
Copy link
Contributor

ozyx commented Jan 20, 2023

Summary

When navigating to an object via a Location Breadcrumb such as those in the Grand Search's search results or in Recent Objects, the URL hash is not updated. This will block e2e tests in certain situations if we need to wait for a URL update to confirm navigation has completed. This will also cause the tree to fail to highlight the focused item as the current location does not change.

Expected vs Current Behavior

The URL hash should always reflect the currently focused object

Steps to Reproduce

  1. Navigate to an object via the Location Breadcrumb either in the GrandSearch results or in Recent Objects
  2. Notice that the currently focused object changes in the object view
  3. Notice that the URL hash doesn't change and no longer reflects the focused object

Environment

  • Open MCT Version: 2.1.6-SNAPSHOT
  • Deployment Type: local
  • OS: MacOS
  • Browser: Chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

Screen.Recording.2023-01-20.at.11.38.34.AM.mov
@shefalijoshi
Copy link
Contributor

Doesn't look like this is fixed - I still see the issue un testathon.

@ozyx
Copy link
Contributor Author

ozyx commented Feb 6, 2023

Doesn't look like this is fixed - I still see the issue un testathon.
@shefalijoshi

Did you see this on Grand Search or in Recent Objects? There may be an edge case that;s not handled

@akhenry
Copy link
Contributor

akhenry commented Feb 9, 2023

Verified fixed.

@shefalijoshi
Copy link
Contributor

Verified Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants