Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notebooks] Formatted entries v1 #6059

Closed
jvigliotta opened this issue Dec 15, 2022 · 5 comments · Fixed by #6090
Closed

[Notebooks] Formatted entries v1 #6059

jvigliotta opened this issue Dec 15, 2022 · 5 comments · Fixed by #6090

Comments

@jvigliotta
Copy link
Contributor

jvigliotta commented Dec 15, 2022

Is your feature request related to a problem? Please describe.
For links in notebook entries, we have had requests to turn them into an actual clickable link.

Describe the solution you'd like
When editing a Notebook entry, if you enter a link, ex: http://www.google.com, when the notebook entry is saved and viewed (not being edited) we'd like to wrap that in an HTML link tag. This should have a target="_blank" blank attribute so the user isn't navigated away from Open MCT.

Describe alternatives you've considered
Markdown formatting.

Additional context
This is just a v1. v2 would include more robust formatting (bold, italic, lists, etc). That issue is here: #6060

@jvigliotta
Copy link
Contributor Author

jvigliotta commented Dec 30, 2022

Testing

  • enter a valid link (http/https) from the whitelist of urls passed into the notebook
  • view the entry, can you click the link? sweet... (if so)
  • now, try to break it
  • now, try to inject some nefarious items (script tags, alerts, etc) and make sure you can't

@charlesh88
Copy link
Contributor

charlesh88 commented Jan 25, 2023

Verified fixed Testathon 2023-01-24.

@rukmini-bose
Copy link
Contributor

Verified Testathon 1/24/2023

@davetsay
Copy link
Contributor

verified but really urls that take up a lot of space make it really really hard to edit the entry.
image

@unlikelyzero
Copy link
Contributor

Filed a follow up as #6218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants