Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Import/Export] Example Display Layouts are broken on Import or Export #5857

Closed
2 of 7 tasks
unlikelyzero opened this issue Oct 7, 2022 · 8 comments
Closed
2 of 7 tasks
Labels
needs:info Needs follow up or investigation severity:blocker type:bug
Milestone

Comments

@unlikelyzero
Copy link
Contributor

unlikelyzero commented Oct 7, 2022

Summary

@charlesh88 created an example display layout which best illustrates a Mission Display. After importing, I noticed that the layouts did not match what was represented in the email

Expected vs Current Behavior

Import
Screen Shot 2022-10-07 at 1 22 50 PM

Exported by Charles
thumbnail_image

Steps to Reproduce

  1. Import the Display Layout from ./e2e/test-data/ExampleDisplayLayout.json
  2. Note how the display does not match the screenshot from the initial export

Environment

  • Open MCT Version: 2.1.1

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?
@charlesh88
Copy link
Contributor

Wow! As mentioned in email, this export was the result of exporting a folder with aliases to two layouts. I've attached that original export here, as well as an export of my My Items folder which holds the two layout's originals.

Newly exported My Items folder that contains the two layouts, as well as a number of other things.
Open MCT Examples 10-05-22.json.zip

The original 'bad' export file cited in the bug.
CH My Items export 10-07-22.json.zip

Correct version of 'Display Layout Example 1'
Screen Shot 2022-10-07 at 2 19 50 PM

Correct version of 'Flexible Layout Example 1'
Screen Shot 2022-10-07 at 2 20 00 PM

@charlesh88
Copy link
Contributor

I tried importing my own previously exported file 'CH My Items export 10-07-22.json.zip' at got these results. In short, the Display Layout was severely broken and identical to what @unlikelyzero observed, while the Flexible Layout is identical to its original.

Screen Shot 2022-10-07 at 2 27 13 PM
Screen Shot 2022-10-07 at 2 27 20 PM

I also reimported my own My Items export, and in that version the Flex Layout was again identical to the original, while the Display Layout was mostly correct, with a misplaced alphanumeric (upper left), which is a known (?) issue:

Screen Shot 2022-10-07 at 2 34 31 PM

A couple thoughts: how do we (do we?) handle in exports Condition Sets that are used by domain objects like Condition Widgets if the export doesn't include a folder that contains them? For example, what happens if the user exports 'Display Layout' below?

> Folder
  > Condition Set
  > Display Layout
    > Condition Widget (that uses Folder > Condition Set)

What location does the Condition Widget's styling Condition Set use? Looking in the 10-05 export JSON file, the '210 Condition Set' object has the property of location: null. Is this part of the problem?

@shefalijoshi
Copy link
Contributor

Are display layout imports that Don't use condition sets also broken?

@shefalijoshi
Copy link
Contributor

@charlesh88 I tried to export a Display layout with a condition widget and condition set like you mentioned and did not have any trouble importing it between Firefox and Chrome browsers on my computer. The layout was fine when imported.
There must be something else going on.

@charlesh88
Copy link
Contributor

charlesh88 commented Oct 7, 2022

@shefalijoshi Some of the elements in use (SWGs, Condition Sets, etc.) are kind of old, so wondering if that’s a factor. I'll see if I can make this happen with freshly made objects.

@shefalijoshi
Copy link
Contributor

I'm unable to reproduce this on either 2.1.1 or 2.1.2 locally. (localhost:8080)
this is what I see when I import it.
image

@unlikelyzero unlikelyzero added the needs:info Needs follow up or investigation label Oct 27, 2022
@unlikelyzero unlikelyzero modified the milestones: Target:2.1.2, 2.1.3 Oct 27, 2022
@unlikelyzero
Copy link
Contributor Author

adding @charlesh88 to help in the investigation

@unlikelyzero
Copy link
Contributor Author

Cannot reproduce with 2.1.1 or 2.1.2. Will close this and remember that it exists 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:info Needs follow up or investigation severity:blocker type:bug
Projects
None yet
Development

No branches or pull requests

4 participants