[Stacked Plot] Removing objects from a stacked plot, will not remove them from the legend

[jvigliotta]

Summary

When you remove an item from a stacked plot, it will continue to be in the legend until you refresh or navigate away and come back. From cursory investigation, these event listeners are never triggered, because they are never fired from series collection.

Definitely needs further investigation.

Expected vs Current Behavior

Items should be removed from the legend, when removed from a stacked plot.

Steps to Reproduce

1. view a stacked plot
2. remove an item
3. notice it has not been removed from the legend

Environment

• Open MCT Version:
• Deployment Type:
• OS:
• Browser:

Impact Check List

• Data loss or misrepresented data?
• Regression? Did this used to work or has it always been broken?
• Is there a workaround available?
• Does this impact a critical component?
• Is this just a visual bug with no functional impact?
• Does this block the execution of e2e tests?
• Does this have an impact on Performance?

Additional Information

[shefalijoshi]

Not a dupe - this is for stacked plots. That one is for overlay plots

[scottbell]

The issue appears to be we're creating at least two versions of a SeriesCollection per StackedPlot - one for the StackedPlot itself, and one for each telemetry item added. The invocations are here and here.

We're listening to the StackedPlotItem version of the SeriesCollection, which never fires an add nor a remove event. I think we want to instead register with StackedPlot's own SeriesCollection, which actually does fire on add and remove.

[rukmini-bose]

Unverified Testathon 1/24/23

When I add plots to a stacked plot, then remove one from the elements pool, that element does get deleted, but the remaining plot gets duplicated in the canvas and legend.

Note the two pics below: I added enabledFlag and a Sine Wave Generator to a stacked plot. I then deleted enabledFlag, and in the second picture, notice that enabledFlag is deleted, but now there are 2 Sine Wave Generators in the canvas and legend, but there's only ONE element in the elements pool.

Do note though, refreshing fixes this problem.

[charlesh88]

Verified fixed Testathon 2023-01-24.

[unlikelyzero]

Assigning to @rukmini-bose and @charlesh88 to determine what to do with the current state

[rukmini-bose]

The behavior I commented on happens pretty often. I think we need to fix this. This could be considered data loss– especially if removing one plot is removing the wrong one.

[charlesh88]

This needs to be fixed if at all possible, it leads to very confusing and misleading states while editing a stacked plot.

[shefalijoshi]

this should be fixed by #6206

[ozyx]

Verified fixed 02-02-2023