Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Grand Search] Duplicate search results when using CouchDB #5690

Closed
3 of 7 tasks
ozyx opened this issue Aug 22, 2022 · 5 comments · Fixed by #5693
Closed
3 of 7 tasks

[Grand Search] Duplicate search results when using CouchDB #5690

ozyx opened this issue Aug 22, 2022 · 5 comments · Fixed by #5693
Labels
bug:regression It used to work. Now it doesn't :( severity:critical type:bug
Milestone

Comments

@ozyx
Copy link
Contributor

ozyx commented Aug 22, 2022

Summary

Seeing duplicate search results when using CouchDB as persistence store. Both duplicates navigate to the correct object.

Expected vs Current Behavior

Steps to Reproduce

  1. Start a fresh Open MCT instance with CouchDB plugin as persistence store
  2. Create a uniquely named object
  3. Search for it in the Grand Search
  4. Notice two duplicate search entries appear

Environment

Seen locally and in live test environment

Version: 2.0.8
Build Date: Mon Aug 22 2022 15:05:20 GMT-0700 (Pacific Daylight Time)
Revision: 06b321588ecef292730f671e5fb850b7b5e1e6ab
Branch: release/2.0.8

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

image

@ozyx
Copy link
Contributor Author

ozyx commented Aug 22, 2022

Regression of #4667

@shefalijoshi
Copy link
Contributor

Initial investigation, root cause:
It appears that when searching,

  1. The CouchObject provider AND the in-memory search provider support searching for 'OBJECTS'. See: https://github.com/nasa/openmct/blob/master/src/api/objects/ObjectAPI.js#L282
  2. They both return results when searching for a given string
  3. The results are then flattened and displayed as duplicate results

@ozyx
Copy link
Contributor Author

ozyx commented Aug 23, 2022

Testing Instructions

  • Create an object. Name it uniquely using a generated uuid
  • Search for it in the grand search
  • Verify that there is only a single search result

@jvigliotta
Copy link
Contributor

Verified Fixed: Testathon 8/23

No more dupes

@unlikelyzero
Copy link
Contributor

Verified

@unlikelyzero unlikelyzero added this to the Target:2.0.8 milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:regression It used to work. Now it doesn't :( severity:critical type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants