Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time list views should support following remote clock, not just wall clock #5629

Closed
akhenry opened this issue Aug 8, 2022 · 9 comments · Fixed by #6082 or #6495
Closed

Time list views should support following remote clock, not just wall clock #5629

akhenry opened this issue Aug 8, 2022 · 9 comments · Fixed by #6082 or #6495
Labels
Milestone

Comments

@akhenry
Copy link
Contributor

akhenry commented Aug 8, 2022

Summary

The time list view shows a time-ordered list of plan activities, with an indication of now in the form of a vertical line.

The time list view should be enhanced to be able to follow a remote clock in order to support systems that use simulated time. This will be essential for using the time list view in VIPER simulations.

We need to think about how to approach this from an API perspective. Some outstanding questions:

  1. Open MCT supports multiple clocks -so which one do we follow?
  2. Right now clocks only tick when started (typically by selecting it from the time conductor). This enhancement implies the presence of an always ticking global clock to replace global wall-clock time.
@michaelrogers
Copy link
Contributor

How to test

  • Navigate to a timelist
  • Select fixed time
  • Observe that all available events are shown irrespective of past, present, or future (this behavior should be consistent with clicking on edit mode)

@ozyx
Copy link
Contributor

ozyx commented Sep 15, 2022

Testathon 9/15/22:

I noticed that in fixed time mode, if you edit the properties and hit 'save', those settings seem to override. Is this behavior intended?

Screen.Recording.2022-09-15.at.3.57.41.PM.mov

It's also a bit confusing visually if you set them all to "Don't Show" and then change time conductor mode to fixed time and they all show up. Is this intended? Maybe there's some way we can make this behavior more apparent in the UI? I doubt we want to actually modify the object properties based on time conductor mode-- that seems bad.

Screen Shot 2022-09-15 at 4 00 37 PM

@shefalijoshi
Copy link
Contributor

shefalijoshi commented Sep 15, 2022

Verified partially fixed.

  1. Navigate to a timelist view in local clock mode
  2. Switch to fixed timespan - verify that all activities are shown
  3. Refresh the browser
  4. Observe that the timelist is empty, expectation is that all activities should be displayed.

@shefalijoshi
Copy link
Contributor

Reopening this as it did not follow the remote clock, only the local clock

@ozyx
Copy link
Contributor

ozyx commented Dec 29, 2022

Testathon 12/29/2022:

Verified fixed on both 2.1.5 and 2.1.4-ERT.

@unlikelyzero unlikelyzero added the needs:e2e Needs an e2e test label Dec 29, 2022
@shefalijoshi
Copy link
Contributor

Reopening as this wasn't working for remote clock on banner.

@akhenry
Copy link
Contributor Author

akhenry commented Mar 29, 2023

This was incorrectly verified fixed. It appears that the verification steps provided were for another issue.

@shefalijoshi
Copy link
Contributor

Testing instructions:

  1. Set the clock to 'Remote clock'.
  2. Create a Timelist from the create menu
  3. Drag a plan into the timelist and save it
  4. Observe the start and end times and the duration - Ensure that the start and end times are in ISO format (if applicable)
  5. Ensure that the duration calculation is correct when you subtract the start time from the current time.
  6. Ensure that any activities in the current time range are shown as such.
  7. Switch from Remote Clock to Local Clock.
  8. Observe the start and end times and the duration.
  9. Ensure that the duration calculation is correct when you subtract the start time from the current time.

@charlesh88
Copy link
Contributor

charlesh88 commented Mar 30, 2023

Verified fixed Testathon 2023-03-30 on /testathon and /stable. New issue seen for scroll behavior and will file as such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment