Disallow move and link to child object

[akhenry]

Summary

Currently the move and link actions allow an object to be moved or linked to a child of itself. This creates a circular reference. A circular link is actually recoverable, but a circular move is not and will cause the UI to freeze. In any case, neither should be allowed.

Expected vs Current Behavior

User should not be able to select a child folder as a target location for a move or link action.

Steps to Reproduce

1. Create a folder called Parent Folder
2. Create a folder called Child Folder as a child of the Parent Folder
3. Create a folder called Grandchild Folder as a child of the Child Folder
4. Context click on the Parent Folder and select "move"
5. Select Grandchild Folder as the new location
6. Observe that the UI hangs

Environment

• Open MCT Version: 2.0.7
• Deployment Type: all

Impact Check List

• Data loss or misrepresented data?
• Regression? Did this used to work or has it always been broken?
• Is there a workaround available?
• Does this impact a critical component?
• Is this just a visual bug with no functional impact?
• Does this block the execution of e2e tests?
• Does this have an impact on Performance?

Additional Information

[scottbell]

I think with the latest fix for infinite loops, the UI is no longer freezing, but the folder does disappear when creating the cyclic reference (as the folder is no longer reachable from the root tree object):

Screen.Recording.2022-08-09.at.1.06.51.PM.mov

I'll next try to prevent move/link actions from selecting descendants as targets.

[jvigliotta]

Verified Fixed - Testathon 8/22

I'm unable to select a descendent for either move or link. Nice!