Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old stacked plot objects broken with console error #5420

Closed
5 of 7 tasks
davetsay opened this issue Jun 30, 2022 · 4 comments
Closed
5 of 7 tasks

Old stacked plot objects broken with console error #5420

davetsay opened this issue Jun 30, 2022 · 4 comments
Labels
bug:regression It used to work. Now it doesn't :( severity:blocker type:bug
Milestone

Comments

@davetsay
Copy link
Contributor

Summary

Seeing a console error when trying to view an old stacked plot object and the stacked plot does not render.
Probably related to #5198

vue.js?7193:634 [Vue warn]: Error in mounted hook: "TypeError: Cannot read properties of undefined (reading 'find')"

found in

---> <StackedPlotItem> at src/plugins/plot/stackedPlot/StackedPlotItem.vue
       <StackedPlot> at src/plugins/plot/stackedPlot/StackedPlot.vue
         <Root>
warn @ vue.js?7193:634
vue.js?7193:1906 TypeError: Cannot read properties of undefined (reading 'find')
    at VueComponent.getPlotObject (StackedPlotItem.vue?76c1:227:1)
    at VueComponent.updateView (StackedPlotItem.vue?76c1:135:1)
    at VueComponent.mounted (StackedPlotItem.vue?76c1:99:1)
    at invokeWithErrorHandling (vue.js?7193:1872:1)
    at callHook (vue.js?7193:4236:1)
    at Object.insert (vue.js?7193:3165:1)
    at invokeInsertHook (vue.js?7193:6385:1)
    at VueComponent.patch [as __patch__] (vue.js?7193:6602:1)
    at Vue._update (vue.js?7193:3964:1)
    at VueComponent.updateComponent (vue.js?7193:4082:1)

Expected vs Current Behavior

Stacked plots should work regardless of when they were created

Steps to Reproduce

  1. Navigate to a plot object created before Selection of stacked plot items and customizing them #5198 was merged in

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@davetsay davetsay added the bug:regression It used to work. Now it doesn't :( label Jun 30, 2022
@shefalijoshi
Copy link
Contributor

shefalijoshi commented Jul 1, 2022

We need an interceptor for Stacked plots that don't have configuration.
For an example of how to write an interceptor, See: https://github.com/nasa/openmct/blob/release/2.0.5/src/plugins/timeline/timelineInterceptor.js

@ozyx
Copy link
Contributor

ozyx commented Jul 8, 2022

Not fixed. Testathon 7/8/22

Still seeing this when viewing an old stacked plot:

image

@ozyx
Copy link
Contributor

ozyx commented Jul 8, 2022

Verified Testathon 7/8/22:

After redeploy, not seeing errors anymore, just the 'Missing domain object' warning when viewing an older stacked plot

@davetsay
Copy link
Contributor Author

davetsay commented Jul 8, 2022

verified locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:regression It used to work. Now it doesn't :( severity:blocker type:bug
Projects
None yet
Development

No branches or pull requests

6 participants