Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Display Layout] Fix non functioning render test #5310

Closed
jvigliotta opened this issue Jun 8, 2022 · 2 comments · Fixed by #5311
Closed

[Display Layout] Fix non functioning render test #5310

jvigliotta opened this issue Jun 8, 2022 · 2 comments · Fixed by #5311
Labels
type:maintenance tests, chores, or project maintenance
Milestone
Target:2.0.5

Comments

@jvigliotta
Copy link
Contributor

Summary

Render test for display was checking for errors, not that the display rendered, which it didin't.

Expected vs Current Behavior

To check that the display rendered.

Steps to Reproduce

  1. Run test coverage
@jvigliotta jvigliotta self-assigned this Jun 8, 2022
@jvigliotta jvigliotta mentioned this issue Jun 8, 2022
Merged
15 tasks
@jvigliotta
Copy link
Contributor Author

Testing

  • run npm run test verify no display layout test errors

@jvigliotta jvigliotta removed the needs:test instructions Missing testing notes label Jun 9, 2022
@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 06/15/2022

@unlikelyzero unlikelyzero added type:maintenance tests, chores, or project maintenance and removed type:bug labels Jul 17, 2022
@unlikelyzero unlikelyzero added this to the Target:2.0.5 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target:2.0.5
Development

Successfully merging a pull request may close this issue.

[Display Layout] Fix broken render test nasa/openmct
4 participants
@khalidadil @shefalijoshi @jvigliotta @unlikelyzero