Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unit Tests] Get test:watch working again #5306

Closed
unlikelyzero opened this issue Jun 8, 2022 · 5 comments · Fixed by #5337
Closed

[Unit Tests] Get test:watch working again #5306

unlikelyzero opened this issue Jun 8, 2022 · 5 comments · Fixed by #5337
Labels
type:maintenance tests, chores, or project maintenance
Milestone

Comments

@unlikelyzero
Copy link
Contributor

Summary

At some point, the test:watch npm script was broken. Let's get it working again!

@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Jun 8, 2022
@ozyx
Copy link
Contributor

ozyx commented Jun 9, 2022

I was looking into this a little bit earlier today, and I noticed that running test:watch causes karma to run the tests over and over again in a loop (it keeps detecting file changes). Is this the broken state of which you speak?

Running it in verbose mode, karma says it keeps detecting file changes after each test run has completed. So I wonder if some files are being watched that shouldn't be?

@unlikelyzero
Copy link
Contributor Author

@ozyx this doesn't have any priority right now, but that's the behavior that I just saw. I haven't used it before so it's possible that it hasn't worked for years

@unlikelyzero
Copy link
Contributor Author

Testing Notes

Run test:watch and verify that the tests are retriggered ONLY when modify the testcode or the application code
npm run test:watch

@jvigliotta
Copy link
Contributor

Not Fixed Locally: Testathon: 7/8/22

This looks to be running in a loop...

@alizenguyen
Copy link
Contributor

Testathon 7/11/22: confirmed looping when run locally

@unlikelyzero unlikelyzero added this to the Target:2.0.7 milestone Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants